Handle single packaging type filter

This commit is contained in:
beatz174-bit
2025-11-23 16:08:17 +10:00
parent c29c779fd8
commit af0931f86c
2 changed files with 164 additions and 4 deletions
+121 -1
View File
@@ -1,5 +1,5 @@
import { MemoryRouter, Route, Routes } from 'react-router-dom';
import { render, screen, within } from '@testing-library/react';
import { render, screen, waitFor, within } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { describe, expect, it, vi, beforeEach } from 'vitest';
import { ActivePickListScreen } from './ActivePickListScreen';
@@ -327,6 +327,126 @@ describe('ActivePickListScreen product search', () => {
expect(itemLabels).toEqual(['Apple Juice', 'Chips', 'Cola', 'Cola']);
});
it('disables packaging filters and selects units when only unit packaging is present', () => {
pickItemsMock.mockReturnValue([
{
id: 'item-1',
pick_list_id: 'list-1',
product_id: 'prod-1',
quantity: 1,
is_carton: false,
status: 'pending',
created_at: 0,
updated_at: 0,
},
]);
render(
<MemoryRouter initialEntries={['/pick-lists/1']}>
<Routes>
<Route path="/pick-lists/:id" element={<ActivePickListScreen />} />
</Routes>
</MemoryRouter>,
);
expect(screen.getByRole('radio', { name: /all/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /cartons/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /units/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /units/i })).toBeChecked();
});
it('disables packaging filters and selects cartons when only carton packaging is present', () => {
pickItemsMock.mockReturnValue([
{
id: 'item-1',
pick_list_id: 'list-1',
product_id: 'prod-1',
quantity: 1,
is_carton: true,
status: 'pending',
created_at: 0,
updated_at: 0,
},
]);
render(
<MemoryRouter initialEntries={['/pick-lists/1']}>
<Routes>
<Route path="/pick-lists/:id" element={<ActivePickListScreen />} />
</Routes>
</MemoryRouter>,
);
expect(screen.getByRole('radio', { name: /all/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /cartons/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /units/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /cartons/i })).toBeChecked();
});
it('resets the filter when the selected packaging type is unavailable', async () => {
const user = userEvent.setup();
pickItemsMock.mockReturnValue([
{
id: 'item-1',
pick_list_id: 'list-1',
product_id: 'prod-1',
quantity: 1,
is_carton: true,
status: 'pending',
created_at: 0,
updated_at: 0,
},
{
id: 'item-2',
pick_list_id: 'list-1',
product_id: 'prod-2',
quantity: 1,
is_carton: false,
status: 'pending',
created_at: 0,
updated_at: 0,
},
]);
const { rerender } = render(
<MemoryRouter initialEntries={['/pick-lists/1']}>
<Routes>
<Route path="/pick-lists/:id" element={<ActivePickListScreen />} />
</Routes>
</MemoryRouter>,
);
await user.click(screen.getByRole('radio', { name: /cartons/i }));
expect(screen.getByRole('radio', { name: /cartons/i })).toBeChecked();
pickItemsMock.mockReturnValue([
{
id: 'item-2',
pick_list_id: 'list-1',
product_id: 'prod-2',
quantity: 1,
is_carton: false,
status: 'pending',
created_at: 0,
updated_at: 0,
},
]);
rerender(
<MemoryRouter initialEntries={['/pick-lists/1']}>
<Routes>
<Route path="/pick-lists/:id" element={<ActivePickListScreen />} />
</Routes>
</MemoryRouter>,
);
await waitFor(() => expect(screen.getByRole('radio', { name: /cartons/i })).toBeDisabled());
expect(screen.getByRole('radio', { name: /all/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /units/i })).toBeDisabled();
expect(screen.getByRole('radio', { name: /units/i })).toBeChecked();
});
it('hides picked items when show picked is unchecked', async () => {
pickItemsMock.mockReturnValue([
{
+43 -3
View File
@@ -98,6 +98,14 @@ export const ActivePickListScreen = () => {
);
}, [products]);
const hasCartonItems = useMemo(() => items.some((item) => item.is_carton), [items]);
const hasUnitItems = useMemo(() => items.some((item) => !item.is_carton), [items]);
const packagingTypeCount = useMemo(
() => Number(hasCartonItems) + Number(hasUnitItems),
[hasCartonItems, hasUnitItems],
);
const disablePackagingSelection = packagingTypeCount === 1;
const filteredProducts = useMemo(() => {
const normalizedQuery = query.trim().toLowerCase();
if (!normalizedQuery) return sortedProducts;
@@ -121,6 +129,23 @@ export const ActivePickListScreen = () => {
}
}, [allItemsPicked, showPicked]);
useEffect(() => {
if (packagingTypeCount === 1) {
const singlePackagingFilter = hasCartonItems ? 'cartons' : 'units';
if (itemFilter !== singlePackagingFilter) {
setItemFilter(singlePackagingFilter);
}
return;
}
if (itemFilter === 'cartons' && !hasCartonItems) {
setItemFilter(hasUnitItems ? 'units' : 'all');
} else if (itemFilter === 'units' && !hasUnitItems) {
setItemFilter(hasCartonItems ? 'cartons' : 'all');
}
}, [itemFilter, hasCartonItems, hasUnitItems, packagingTypeCount]);
const visibleItems = useMemo(() => {
let filteredItems = showPicked
? sortedItems
@@ -310,9 +335,24 @@ export const ActivePickListScreen = () => {
}
sx={{ flexGrow: 1 }}
>
<FormControlLabel value="all" control={<Radio />} label="All" />
<FormControlLabel value="cartons" control={<Radio />} label="Cartons" />
<FormControlLabel value="units" control={<Radio />} label="Units" />
<FormControlLabel
value="all"
control={<Radio />}
label="All"
disabled={disablePackagingSelection}
/>
<FormControlLabel
value="cartons"
control={<Radio />}
label="Cartons"
disabled={disablePackagingSelection || !hasCartonItems}
/>
<FormControlLabel
value="units"
control={<Radio />}
label="Units"
disabled={disablePackagingSelection || !hasUnitItems}
/>
</RadioGroup>
<Stack direction="row" spacing={1} alignItems="center" sx={{ ml: { xs: 0, sm: 2 } }}>
<FormControlLabel