beatzaplenty/nixos
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace duplicate-host check with live Proxmox query; drop deployedTargets #6

Merged
beatzaplenty merged 2 commits from fix-duplicate-host-self-match into main 2026-07-20 10:13:07 +00:00
Conversation 0 Commits 2 Files Changed 4
+69 -47
2 Commits
Author SHA1 Message Date
rootandClaude Sonnet 5 86a1660adc Replace the duplicate-host check with a live Proxmox query, drop deployedTargets
Check NixOS configurations / eval-hosts (pull_request) Failing after 11m19s
Details 
variables.nix's deployedTargets was a manually-maintained list with no
enforcement keeping it in sync with reality -- it caused two separate
false refusals in a row (naming a VM as deployed well after it had been
destroyed, then matching a target against itself once the list was
"corrected"). Static files can't track whether a resource still actually
exists.

create-proxmox-resource.sh's duplicate-host guard now queries the
Proxmox node directly (qm/pct's own name/hostname config, matched
against --host) instead. Also fixes a gap in that live check: it
originally swallowed ssh failures and would have silently treated "can't
reach the node" the same as "checked, nothing there" -- it now refuses
instead of guessing when the node can't be reached.

deployedTargets is removed entirely from variables.nix since nothing
else in the repo consumed it once this script no longer does; README.md's
Hosts table remains the sole source of truth for "(real, deployed)"
status. CLAUDE.md and the script's own --help/comments updated to match.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
 2026-07-20 10:03:00 +00:00
rootandClaude Sonnet 5 6522a35115 Don't refuse recreating the canonical already-deployed target itself
Check NixOS configurations / eval-hosts (pull_request) Failing after 11m13s
Details 
The duplicate-host check in create-proxmox-resource.sh compared by
hostName only, so it fired even when the target being created was
exactly the one variables.nix's deployedTargets already names (e.g.
rebuilding lxc-nix-cache after destroying its old container to pick up
new sops secrets) -- there's no other machine at risk of an identity
collision in that case, just the normal redeploy workflow. Skip the
check when dt == flake_target; the later VMID-existence check still
guards against clobbering a resource that's actually live on the node.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
 2026-07-20 09:49:31 +00:00