Wrap auto-install.sh in a nix-shell shebang for its required tools #38

2026-07-22T02:45:28Z

beatzaplenty commented

2026-07-22 02:45:28 +00:00

Running the script standalone (its whole point per the last commit)
failed with "disko: command not found" -- jq/disko/nixos-install are
only guaranteed present via the built installer image's
environment.systemPackages, not on a plain checkout.

Added a #!/usr/bin/env nix-shell / #!nix-shell -i bash -p jq disko
nixos-install-tools shebang instead of a per-tool fallback: disko's own
generated scripts already hardcode absolute Nix store paths for
everything they shell out to internally (parted/sgdisk/mkfs.*/zfs/...
confirmed by inspecting a generated system.build.formatScript earlier),
so these three are the only genuinely external dependencies the script
itself has. This is a fast no-op on the built installer image (already
has all three) and what makes it also work standalone.

Quick syntax + shellcheck pass only this round (bash -n, shellcheck
with a shellcheck shell=bash directive since it doesn't recognize
nix-shell shebangs natively) -- skipping the full codex-maintenance.sh
sweep per request, to get this out for a real hardware test.

Running the script standalone (its whole point per the last commit) failed with "disko: command not found" -- jq/disko/nixos-install are only guaranteed present via the built installer image's environment.systemPackages, not on a plain checkout. Added a #!/usr/bin/env nix-shell / #!nix-shell -i bash -p jq disko nixos-install-tools shebang instead of a per-tool fallback: disko's own generated scripts already hardcode absolute Nix store paths for everything they shell out to internally (parted/sgdisk/mkfs.*/zfs/... confirmed by inspecting a generated system.build.formatScript earlier), so these three are the only genuinely external dependencies the script itself has. This is a fast no-op on the built installer image (already has all three) and what makes it also work standalone. Quick syntax + shellcheck pass only this round (bash -n, shellcheck with a `shellcheck shell=bash` directive since it doesn't recognize nix-shell shebangs natively) -- skipping the full codex-maintenance.sh sweep per request, to get this out for a real hardware test.

beatzaplenty added 1 commit 2026-07-22 02:45:29 +00:00

Wrap auto-install.sh in a nix-shell shebang for its required tools

Check NixOS configurations / eval-hosts (pull_request) Successful in 10m20s

Details

b46424343f

Running the script standalone (its whole point per the last commit)
failed with "disko: command not found" -- jq/disko/nixos-install are
only guaranteed present via the built installer image's
environment.systemPackages, not on a plain checkout.

Added a #!/usr/bin/env nix-shell / #!nix-shell -i bash -p jq disko
nixos-install-tools shebang instead of a per-tool fallback: disko's own
generated scripts already hardcode absolute Nix store paths for
everything they shell out to internally (parted/sgdisk/mkfs.*/zfs/...
confirmed by inspecting a generated system.build.formatScript earlier),
so these three are the only genuinely external dependencies the script
itself has. This is a fast no-op on the built installer image (already
has all three) and what makes it also work standalone.

Quick syntax + shellcheck pass only this round (bash -n, shellcheck
with a `shellcheck shell=bash` directive since it doesn't recognize
nix-shell shebangs natively) -- skipping the full codex-maintenance.sh
sweep per request, to get this out for a real hardware test.

beatzaplenty merged commit 5fe575d362 into main

2026-07-22 02:45:35 +00:00

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: beatzaplenty/nixos#38