beatzaplenty/nixos
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ha): resolve data disk device via by-id symlink even in dry-run #105

Merged
beatzaplenty merged 1 commits from worktree-partitioned-swimming-pizza into main 2026-07-29 04:01:50 +00:00
Conversation 0 Commits 1 Files Changed 1
+5 -9
beatzaplenty commented 2026-07-29 04:01:46 +00:00
Owner
Copy Link
Copy Source

The by-id lookup is read-only so it's safe to run in dry-run mode.
Previously it was gated behind if ! $DRY_RUN, which always triggered
the sdb fallback warning in dry-run — making it look like the device
path wasn't reliable when the symlink actually exists on both servers.

Now the lookup always runs and the script errors out with a clear message
if the by-id symlink is genuinely missing, instead of silently falling
back to a guessed /dev/sd* name.

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

The by-id lookup is read-only so it's safe to run in dry-run mode. Previously it was gated behind `if ! $DRY_RUN`, which always triggered the sdb fallback warning in dry-run — making it look like the device path wasn't reliable when the symlink actually exists on both servers. Now the lookup always runs and the script errors out with a clear message if the by-id symlink is genuinely missing, instead of silently falling back to a guessed /dev/sd* name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
beatzaplenty added 1 commit 2026-07-29 04:01:47 +00:00
fix(ha): resolve data disk device via by-id symlink even in dry-run
Check NixOS configurations / eval-hosts (pull_request) Successful in 10m21s
Details
539bdf9833 
The by-id lookup is read-only so it's safe to run in dry-run mode.
Previously it was gated behind `if ! $DRY_RUN`, which always triggered
the sdb fallback warning in dry-run — making it look like the device
path wasn't reliable when the symlink actually exists on both servers.

Now the lookup always runs and the script errors out with a clear message
if the by-id symlink is genuinely missing, instead of silently falling
back to a guessed /dev/sd* name.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
beatzaplenty merged commit b9d3b51028 into main 2026-07-29 04:01:50 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
beatzaplenty
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: beatzaplenty/nixos#105