beatzaplenty/nixos
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Unmount leftover chroot bind mounts before zpool export #42

Merged
beatzaplenty merged 1 commits from worktree-baremetal-emergency-access into main 2026-07-22 04:10:09 +00:00
Conversation 0 Commits 1 Files Changed 1
+15
beatzaplenty commented 2026-07-22 04:09:49 +00:00
Owner
Copy Link
Copy Source

PR #41 was merged (03:48:48) before this second commit was pushed to the same branch, so it never landed on main -- reopening it here.

nixos-install bind-mounts /dev, /proc, /sys (and usually /run) into /mnt to run the target's activation script in a chroot, and doesn't unmount them again afterward. Left in place, those nested mounts made ZFS refuse to unmount its own root dataset at /mnt: zpool export failed with 'cannot unmount /mnt: pool or dataset busy' (confirmed live on a real reinstall), and because auto-install.sh runs under set -e, that killed the script before it ever reached reboot -- silently defeating the export-before-reboot fix from #40 on every real run, which is why the ZFS-import stall kept recurring even after that PR merged.

This is the actual fix for the reboot stall. Verified with bash -n and scripts/codex-maintenance.sh (clean, only pre-existing documented secret-grep exceptions).

PR #41 was merged (03:48:48) before this second commit was pushed to the same branch, so it never landed on main -- reopening it here. nixos-install bind-mounts /dev, /proc, /sys (and usually /run) into /mnt to run the target's activation script in a chroot, and doesn't unmount them again afterward. Left in place, those nested mounts made ZFS refuse to unmount its own root dataset at /mnt: zpool export failed with 'cannot unmount /mnt: pool or dataset busy' (confirmed live on a real reinstall), and because auto-install.sh runs under set -e, that killed the script before it ever reached reboot -- silently defeating the export-before-reboot fix from #40 on every real run, which is why the ZFS-import stall kept recurring even after that PR merged. This is the actual fix for the reboot stall. Verified with bash -n and scripts/codex-maintenance.sh (clean, only pre-existing documented secret-grep exceptions).
beatzaplenty added 1 commit 2026-07-22 04:09:50 +00:00
Unmount nixos-install's leftover chroot bind mounts before zpool export
Check NixOS configurations / eval-hosts (pull_request) Successful in 10m20s
Details
9bb626327f 
nixos-install bind-mounts /dev, /proc, /sys (and usually /run) into
/mnt to run the target's activation script in a chroot, and doesn't
unmount them again afterward. Left in place, those nested mounts made
ZFS refuse to unmount its own root dataset at /mnt: zpool export
failed with "cannot unmount '/mnt': pool or dataset busy", and because
of this script's set -e, that killed the script before it ever reached
reboot -- silently defeating the export-before-reboot fix from #40 on
every real run, which is why the ZFS-import stall kept recurring.
beatzaplenty merged commit 400af07154 into main 2026-07-22 04:10:09 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
beatzaplenty
No Assignees
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: beatzaplenty/nixos#42