Merge pull request #119 from beatz174-bit/codex/fix-e2e-test-failures-in-picklist.spec.ts-5so3cr

Fix mobile pick item dialogs closing properly
This commit is contained in:
beatz174-bit
2025-11-24 10:48:10 +10:00
committed by GitHub
+10 -7
View File
@@ -49,20 +49,22 @@ export const PickItemRow = ({
onStatusChange(checked ? 'picked' : 'pending'); onStatusChange(checked ? 'picked' : 'pending');
}; };
const closeDialogs = () => { const closeDialogs = (event?: { stopPropagation?: () => void }) => {
event?.stopPropagation?.();
setIsConfirmOpen(false); setIsConfirmOpen(false);
setIsControlsOpen(false); setIsControlsOpen(false);
}; };
const handleConfirmDelete = () => { const handleConfirmDelete = (event?: { stopPropagation?: () => void }) => {
event?.stopPropagation?.();
onDelete(); onDelete();
closeDialogs(); closeDialogs();
}; };
const handleRowClick = () => { const handleRowClick = () => {
if (isNarrowScreen) { if (!isNarrowScreen || isControlsOpen) return;
setIsControlsOpen(true);
} setIsControlsOpen(true);
}; };
const openControls = (event: React.SyntheticEvent) => { const openControls = (event: React.SyntheticEvent) => {
@@ -70,7 +72,8 @@ export const PickItemRow = ({
setIsControlsOpen(true); setIsControlsOpen(true);
}; };
const handleCloseControls = () => { const handleCloseControls = (event?: { stopPropagation?: () => void }) => {
event?.stopPropagation?.();
setIsControlsOpen(false); setIsControlsOpen(false);
}; };
@@ -201,7 +204,7 @@ export const PickItemRow = ({
{isNarrowScreen && ( {isNarrowScreen && (
<Dialog <Dialog
open={isControlsOpen} open={isControlsOpen}
onClose={handleCloseControls} onClose={(event) => handleCloseControls(event)}
fullWidth fullWidth
maxWidth="xs" maxWidth="xs"
aria-labelledby="item-controls-title" aria-labelledby="item-controls-title"