diff --git a/src/screens/ActivePickListScreen.test.tsx b/src/screens/ActivePickListScreen.test.tsx index 16e58c0..3de488b 100644 --- a/src/screens/ActivePickListScreen.test.tsx +++ b/src/screens/ActivePickListScreen.test.tsx @@ -500,7 +500,7 @@ describe('ActivePickListScreen product search', () => { expect(itemLabels).toEqual(['Apple Juice', 'Chips', 'Cola', 'Cola']); }); - it('disables packaging filters when only one packaging type is present', () => { + it('keeps packaging filters enabled when items share a single packaging type but mixed statuses', () => { pickItemsMock.mockReturnValue([ { id: 'item-1', @@ -512,6 +512,16 @@ describe('ActivePickListScreen product search', () => { created_at: 0, updated_at: 0, }, + { + id: 'item-2', + pick_list_id: 'list-1', + product_id: 'prod-2', + quantity: 1, + is_carton: false, + status: 'picked', + created_at: 0, + updated_at: 0, + }, ]); render( @@ -522,9 +532,8 @@ describe('ActivePickListScreen product search', () => { , ); - expect(screen.getByRole('radio', { name: /all/i })).toBeChecked(); - expect(screen.getByRole('radio', { name: /cartons/i })).toBeDisabled(); - expect(screen.getByRole('radio', { name: /units/i })).toBeDisabled(); + expect(screen.getByRole('radio', { name: /cartons/i })).toBeEnabled(); + expect(screen.getByRole('radio', { name: /units/i })).toBeEnabled(); }); it('enables and disables packaging filters based on the visible item statuses', async () => { @@ -647,7 +656,9 @@ describe('ActivePickListScreen product search', () => { }, ]); - const { rerender } = render( + const user = userEvent.setup(); + + render( } /> @@ -658,32 +669,14 @@ describe('ActivePickListScreen product search', () => { await user.click(screen.getByRole('radio', { name: /cartons/i })); expect(screen.getByRole('radio', { name: /cartons/i })).toBeChecked(); - pickItemsMock.mockReturnValue([ - { - id: 'item-2', - pick_list_id: 'list-1', - product_id: 'prod-2', - quantity: 1, - is_carton: false, - status: 'pending', - created_at: 0, - updated_at: 0, - }, - ]); + await user.click(screen.getByLabelText(/show picked/i)); - rerender( - - - } /> - - , - ); - - await waitFor(() => expect(screen.getByRole('radio', { name: /cartons/i })).toBeDisabled()); - expect(screen.getByRole('radio', { name: /all/i })).toBeChecked(); + await waitFor(() => expect(screen.getByRole('radio', { name: /all/i })).toBeChecked()); + expect(screen.getByRole('radio', { name: /cartons/i })).toBeDisabled(); expect(screen.getByRole('radio', { name: /units/i })).toBeDisabled(); }); + it('hides picked items when show picked is unchecked', async () => { pickItemsMock.mockReturnValue([ { diff --git a/src/screens/ActivePickListScreen.tsx b/src/screens/ActivePickListScreen.tsx index 971b29b..afe93fc 100644 --- a/src/screens/ActivePickListScreen.tsx +++ b/src/screens/ActivePickListScreen.tsx @@ -220,7 +220,7 @@ export const ActivePickListScreen = () => { } else if (itemFilter === 'units' && !hasUnitItems) { setItemFilter('cartons'); } - }, [itemFilter, hasCartonItems, hasUnitItems, packagingTypeCount]); + }, [itemFilter, packagingFiltersDisabled]); const visibleItems = useMemo(() => { let filteredItems = showPicked @@ -456,13 +456,13 @@ export const ActivePickListScreen = () => { value="cartons" control={} label="Cartons" - disabled={packagingFiltersDisabled || !hasCartonItems} + disabled={packagingFiltersDisabled} /> } label="Units" - disabled={packagingFiltersDisabled || !hasUnitItems} + disabled={packagingFiltersDisabled} />