From 65f765df3a177cd72d9813f8016fa0b6aa5141b7 Mon Sep 17 00:00:00 2001 From: beatz174-bit Date: Sun, 23 Nov 2025 15:42:14 +1000 Subject: [PATCH] Remove category dropdown from pick list creation --- e2e/picklist.spec.ts | 3 +- src/screens/StartPickListScreen.test.tsx | 5 +--- src/screens/StartPickListScreen.tsx | 36 ++++-------------------- 3 files changed, 8 insertions(+), 36 deletions(-) diff --git a/e2e/picklist.spec.ts b/e2e/picklist.spec.ts index 421dd9b..945c423 100644 --- a/e2e/picklist.spec.ts +++ b/e2e/picklist.spec.ts @@ -13,8 +13,7 @@ test.describe('Active pick list', () => { await page.getByRole('link', { name: 'Create Pick List' }).click(); await page.getByLabel('Area').click(); await page.getByRole('option', { name: areaName }).first().click(); - await page.getByLabel('Category (optional)').click(); - await page.getByRole('option', { name: 'Chocolates' }).click(); + await page.getByRole('checkbox', { name: 'Chocolates' }).click(); await page.getByRole('checkbox', { name: 'Chips' }).click(); await page.getByRole('button', { name: 'Save Pick List' }).click(); diff --git a/src/screens/StartPickListScreen.test.tsx b/src/screens/StartPickListScreen.test.tsx index 6f442ad..58f6454 100644 --- a/src/screens/StartPickListScreen.test.tsx +++ b/src/screens/StartPickListScreen.test.tsx @@ -97,7 +97,6 @@ describe('StartPickListScreen', () => { , ); - expect(screen.getByLabelText(/category \(optional\)/i)).toBeVisible(); categoriesMock.forEach((category) => { expect(screen.getByRole('checkbox', { name: category.name })).toBeInTheDocument(); }); @@ -115,9 +114,7 @@ describe('StartPickListScreen', () => { await user.click(screen.getByLabelText(/area/i)); await user.click(screen.getByRole('option', { name: /front counter/i })); - await user.click(screen.getByLabelText(/category \(optional\)/i)); - await user.click(screen.getByRole('option', { name: /drinks/i })); - + await user.click(screen.getByRole('checkbox', { name: /drinks/i })); await user.click(screen.getByRole('checkbox', { name: /snacks/i })); await user.click(screen.getByRole('button', { name: /save pick list/i })); diff --git a/src/screens/StartPickListScreen.tsx b/src/screens/StartPickListScreen.tsx index 147510e..a4fa143 100644 --- a/src/screens/StartPickListScreen.tsx +++ b/src/screens/StartPickListScreen.tsx @@ -23,7 +23,6 @@ export const StartPickListScreen = () => { const [areaId, setAreaId] = useState(''); const [notes, setNotes] = useState(''); const [selectedCategories, setSelectedCategories] = useState([]); - const [quickCategoryId, setQuickCategoryId] = useState(''); const sortedCategories = useMemo( () => @@ -41,16 +40,6 @@ export const StartPickListScreen = () => { ); }; - const handleSelectCategory = (categoryId: string) => { - setQuickCategoryId(categoryId); - if (!categoryId) return; - - setSelectedCategories((current) => - current.includes(categoryId) ? current : [...current, categoryId], - ); - setQuickCategoryId(''); - }; - const start = async () => { if (!areaId) return; const pickListId = uuidv4(); @@ -120,19 +109,13 @@ export const StartPickListScreen = () => { ))} handleSelectCategory(event.target.value as string)} - > - None - {sortedCategories.map((category) => ( - - {category.name} - - ))} - + label="Notes (optional)" + value={notes} + onChange={(event) => setNotes(event.target.value)} + multiline + minRows={2} + /> Add categories to prefill products @@ -150,13 +133,6 @@ export const StartPickListScreen = () => { ))} - setNotes(event.target.value)} - multiline - minRows={2} - />