Merge pull request 'fix(lxc-pxe-boot): make privileged so NFS mounts work' (#78) from worktree-debian-pxe into main

Reviewed-on: #78

modules/platforms/lxc.nix

@@ -63,23 +63,22 @@ in
     # back to decide `pct create`'s --unprivileged flag, so the two stay
     # in sync).
     #
-    # lxc-docker is the one exception: the kernel's NFS client doesn't set
+    # Any lxc-* host with an NFS fileSystem must be privileged: the kernel's
-    # FS_USERNS_MOUNT, so mounting NFS from inside *any* non-init user
+    # NFS client doesn't set FS_USERNS_MOUNT, so mounting NFS from inside
-    # namespace -- which is exactly what an unprivileged container's
+    # *any* non-init user namespace -- which is exactly what an unprivileged
-    # UID-mapped root runs in -- is rejected at the VFS layer with EPERM,
+    # container's UID-mapped root runs in -- is rejected at the VFS layer
-    # no matter what Proxmox's own `mount=nfs;nfs4` container feature
+    # with EPERM, no matter what Proxmox's own `mount=nfs;nfs4` container
-    # allows at the AppArmor layer (confirmed live: TCP to the NFS server
+    # feature allows at the AppArmor layer (confirmed live: TCP to the NFS
-    # succeeds, the server's export table matches the container's IP, and
+    # server succeeds, the server's export table matches the container's IP,
-    # `mount.nfs: Operation not permitted` still fires immediately with no
+    # and `mount.nfs: Operation not permitted` still fires immediately with
-    # corresponding denial anywhere in the server's logs -- a kernel-level
+    # no corresponding denial anywhere in the server's logs -- a kernel-level
-    # rejection, not a network or export-permission one). Keying off
+    # rejection, not a network or export-permission one). Deriving this from
-    # hostName rather than something docker-build-type-specific because
+    # fileSystems rather than a per-host override keeps it self-consistent:
-    # modules/build-types/docker.nix is also composed for linode-docker/
+    # any new lxc-* host that declares an NFS mount automatically gets the
-    # proxmox-docker, which don't import proxmox-lxc.nix at all --setting
+    # privilege level it needs without a separate manual flag.
-    # this option there would break their eval with "option does not
+    privileged = builtins.any
-    # exist" regardless of any mkIf guard, since mkIf only makes a value
+      (fs: fs.fsType == "nfs" || fs.fsType == "nfs4")
-    # conditional, not whether the option needs to exist somewhere.
+      (builtins.attrValues config.fileSystems);
-    privileged = config.networking.hostName == "docker";
   };
 
   boot.loader = {

scripts/proxmox/create-proxmox-resource.sh

@@ -867,17 +867,17 @@ if [[ "$type" == "lxc" ]]; then
   local_swap="${swap:-$memory}"
   # --unprivileged: read back from modules/platforms/lxc.nix's own
   # proxmoxLXC.privileged (via flake_target_lxc_privileged) rather than
-  # hardcoded, since that's no longer the same for every lxc-* target --
+  # hardcoded. lxc.nix derives this automatically: any lxc-* host whose
-  # lxc-docker sets it true so the container's NFS mounts work at all (the
+  # config.fileSystems has an NFS entry gets privileged=true, because the
-  # kernel's NFS client can't mount from inside any unprivileged
+  # kernel's NFS client (FS_USERNS_MOUNT not set) rejects NFS mounts from
-  # container's user namespace, no matter what AppArmor allows -- see that
+  # inside any non-init user namespace -- exactly what an unprivileged
-  # option's own comment). The NixOS config inside the image bakes in
+  # container's UID-mapped root lives in -- with EPERM at the VFS layer,
-  # cgroup/capability/mount expectations matching whichever value it was
+  # regardless of AppArmor (see lxc.nix's own comment). The NixOS config
-  # built with, so this must stay in sync with it -- `pct create`'s own
+  # bakes in cgroup/capability/mount expectations matching whichever value
-  # CLI default for this flag is privileged (unlike the web UI, which
+  # it was built with, so this must stay in sync -- `pct create`'s CLI
-  # defaults its checkbox the other way), so leaving it unset would create
+  # default is privileged (unlike the web UI, which defaults the other
-  # a privileged container running a NixOS config that assumes
+  # way), so leaving it unset would create a privileged container running
-  # unprivileged for every target except lxc-docker, a real mismatch.
+  # a NixOS config that assumes unprivileged, a real mismatch.
   privileged_eval="$(flake_target_lxc_privileged "$repo_root" "$flake_target")"
   unprivileged_flag=1
   [[ "$privileged_eval" == "true" ]] && unprivileged_flag=0